Move end evm hook #164
Open
Move end evm hook #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where parallel txs get flagged)
…where parallel txs get flagged)
Base automatically changed from
fix-sstore-committedstate
to
temp-test-lts-err
November 7, 2024 09:34
|
@eshelB I think you forgot to push the actual evmEnd hook move? anyway, this is a bit more complicated than we initially thought, because the postTxFilter is called only in the sequencer. so to move it to a flow that's happening only in the sequencer would cause all other nodes to not run evmEnd hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved the evmCallEnd hook to after resultFilter, which may generate errors that fheos should be aware of. Now fheos will not save to long-term storage, ciphertexts that exists only on states existing in failed transactions
todo: test