Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate tests #25

Merged
merged 13 commits into from
Dec 19, 2023
Merged

Auto generate tests #25

merged 13 commits into from
Dec 19, 2023

Conversation

liorbond
Copy link
Collaborator

@liorbond liorbond commented Dec 16, 2023

@liorbond liorbond changed the base branch from master to fix-solgen December 16, 2023 23:27
Copy link
Contributor

@eshelB eshelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! auto-generated tests. +1 for me
Here are the things I had friction with:

  1. had to install tsc
  2. had to remove this line from package.json, otherwise I would get stuck in an infinite loop when pnpm installing on the solgen dir
  3. had to run pnpm install first on the solidity dir too
  4. copied .env.example into .env
  5. run my local node
  6. fund wallet
    and that's it! Now it worked. saw a few logs about "execution reverted", but all the tests were marked with a "v".
    Awesome!
    Only thing left is to remove that line in solgen/package.json and that's it, so I approve

solidity/tests/utils.ts Show resolved Hide resolved
precompiles/contracts.go Show resolved Hide resolved
solgen/solgen.js Show resolved Hide resolved
solgen/templates.ts Show resolved Hide resolved
solidity/hardhat.config.ts Show resolved Hide resolved
Base automatically changed from fix-solgen to master December 18, 2023 09:24
@liorbond liorbond merged commit 2390807 into master Dec 19, 2023
1 check failed
@liorbond liorbond deleted the auto-generate-tests branch December 19, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants