Add query arg to suggestionTemplate function #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
templateSuggestion
function to take an additionalquery
parameter (the text which was typed into the autocomplete text input field by the user).This means that the Origami o-autocomplete component (which relies on accessible-autocomplete) can provide a
suggestionTemplate
in the options when instantiating an instance ofoAutocomplete
which can use thatquery
value in its callback.This will enable a customised rendering of suggestion items whilst retaining the ability to apply highlighting (for which the
query
value is necessary) on theoption
value (or, in the scenario of it being an object, values thereof).Dependent PRs
Dependent PRs
TODO
ERROR: Permission to alphagov/accessible-autocomplete.git denied to andygout
), and based on this commit, I think only Jake Champion had them, @notlee? Though it may not be reviewed in any case based on Types of support we can provide. alphagov/accessible-autocomplete#430.Release
This adds functionality in a backwards-compatible manner so I propose to release these changes as a minor version.