This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Add a check in the task runner to wait for dependents to finish #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-like-robots
force-pushed
the
matth/depends-on
branch
from
December 4, 2018 11:34
b4bc7e7
to
dc17d5a
Compare
i-like-robots
commented
Dec 7, 2018
…ended upon packages are complete 🐿 v2.10.0
i-like-robots
force-pushed
the
matth/depends-on
branch
from
December 7, 2018 11:01
be18186
to
64c637b
Compare
i-like-robots
force-pushed
the
matth/depends-on
branch
from
December 7, 2018 14:36
85c73ce
to
260eb36
Compare
🐿 v2.10.0
i-like-robots
force-pushed
the
matth/depends-on
branch
from
December 7, 2018 14:59
260eb36
to
f74bb55
Compare
…itter.removeEvent() 🐿 v2.10.0
…hen the flag is on 🐿 v2.10.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice!
apaleslimghost
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops that was meant to be ✅
magsallen
reviewed
Dec 13, 2018
@@ -93,18 +93,25 @@ athloi publish -- --access=public | |||
|
|||
### concurrency | |||
|
|||
A global concurrency option which can be used to execute multiple tasks in parallel. By default only one task will run at a time. | |||
A global option which will execute up to the given number of tasks concurrently. By default one task will be run at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an upper-limit to the number of tasks we can run concurrently? 🤔
ifeanyiisitor
approved these changes
Dec 13, 2018
magsallen
reviewed
Dec 13, 2018
magsallen
reviewed
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds logic to improve the usage of the
--concurrency
option with a new--preserve-order
flag.Why
Running concurrent tasks is great, but not always. This is because tasks can be kicked off for packages which may depend on another package that has not yet finished running... e.g.:
How
This PR adds an additional queue to the semaphore concurrency pattern which ensures tasks can wait until any dependent packages finish running. There are a number of changes to aid this:
allDependencies
property to the package wrapper class as this was duplicated in several placesI tested by running various tasks within the the x-dash repository.
Show
Usage: