Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Ignore glob matches which are not directories containing a package.json #30

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

i-like-robots
Copy link
Contributor

@i-like-robots i-like-robots commented Feb 14, 2019

🤦‍♂️

The glob match will find both files and folders which Athloi has until now not checked. I have updated this so that it checks two things:

  1. That the glob match is a directory and not a file
  2. That a package manifest exists at that path and throw and clear error if it does not

Example error from previous behaviour:

✖ Task failed: "Cannot find module '/Users/matt.hinchliffe/Projects/anvil/examples/readme.md/package.json'"

🐿 v2.10.0

@i-like-robots i-like-robots added bug Something that is broken feature Addition of new functionality labels Feb 14, 2019
@i-like-robots i-like-robots merged commit b3b00ae into master Feb 14, 2019
@i-like-robots i-like-robots deleted the matth/ignore-glob-matches-without-manifest branch February 14, 2019 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that is broken feature Addition of new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant