Only require latest version of Node tests to pass to publish #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an issue with the CircleCI workflow where depending on both the Node 16 and Node 18 test jobs to pass meant that we could not attach the workspace to the publish job as the `node_modules` directory in the test jobs conflicted. The downside now is that we will automatically publish the package even if the Node 16 tests fail. I don't think CircleCI provides any way to work around this when testing mutiple Node versions concurrently (there's no way to select which job to attach a workspace from, for instance).
joelcarr
approved these changes
May 30, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an issue with the CircleCI workflow where depending on both the Node 16 and Node 18 test jobs to pass meant that we could not attach the workspace to the publish job as the
node_modulesdirectory in the test jobs conflicted. The downside now is that we will automatically publish the package even if the Node 16 tests fail. I don't think CircleCI provides any way to work around this when testing mutiple Node versions concurrently (there's no way to select which job to attach a workspace from, for instance).