Decouple Storybook from docs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-like-robots
added
documentation
robsquires
reviewed
May 17, 2019
| class StoryViewer extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
| const StoryViewer = ({ name }) => { |
|
LGTM |
robsquires
previously approved these changes
May 17, 2019
i-like-robots
commented
May 17, 2019
| @@ -22,7 +22,7 @@ export default ({ name, manifest, storybook }) => ( | |||
| </li> | |||
| {storybook ? ( | |||
| <li className="tertiary-menu__item"> | |||
| <Link to={`/storybook/index.html?selectedKind=${name}`} {...linkProps}> | |||
| <Link to={`/storybook/index.html?path=/story/${name}--*`} {...linkProps}> | |||
There was a problem hiding this comment.
This requires Storybook 5.1.0 (when it is available)
i-like-robots
commented
May 17, 2019
| <div id="component-demos" className="story-viewer"> | ||
| <h2 className="story-viewer__heading">Component demos</h2> | ||
| <div className="story-viewer__panel"> | ||
| <iframe title={`${name} demo`} src={iframeUrl}></iframe> |
There was a problem hiding this comment.
Gatsby won't be able to serve this static file when in develop mode as it uses a .html extension.
rowanbeentje
pushed a commit
that referenced
this pull request
Nov 24, 2021
…-from-docs Decouple Storybook from docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the Gatsby from loading story files and component source files.
The change is required because #275 enabled component stories to include source files instead of restricting them to the distributable code bundle and Gatsby may break if it attempts to load these files.
To achieve this I have added ignore rules to the filesystem plugin and refactored the package page logic to check only if component story files exist but actually load it.
This limits the UI somewhat, so I have made it simpler by removing the individual story tabs and simply enabling Storybook links if a story file is found.
Please note:
.htmlextension, [gatsby develop] Properly serve HTML files in the static directory gatsbyjs/gatsby#13072