Code

x-follow-button#59

Code

Merged

edds merged 36 commits intomasterFinancial-Times/x-dash:masterfrom follow-buttonFinancial-Times/x-dash:follow-buttonCopy head branch name to clipboardDec 4, 2019

+596-7

Commits

Commits on Nov 14, 2019

• Original development of x-follow-button using x-interaction (largely obsolete).

  

  Katerina

  authored and

  kateloschinina

  committed
  41eaed9

• Set main entry in bower.json to enable imports via Bower to resolve. (+1 squashed commit)

  Show description for 9709478
  

  Katerina

  authored and

  kateloschinina

  committed
  9709478

• Tidy up after rebase.

  

  Dan Searle

  authored and

  kateloschinina

  committed
  ef56c8a

• Update knobs for Storybook 4 (+1 squashed commit)

  Show description for 92b229f
  

  Dan Searle

  authored and

  kateloschinina

  committed
  92b229f

• Dispatch custom event on click of button. Expose more meaningful actions. No need for a separate onClick handler.

  

  Dan Searle

  authored and

  kateloschinina

  committed
  d9adab3

• Remove data-myft-ui to prevent n-myft-ui generic button handling. (+1 squashed commit)

  Show description for 93873f4
  

  Dan Searle

  authored and

  kateloschinina

  committed
  93873f4

• Refactor to not use x-interaction. Also simplify the button as it now expects to get rendered by its parent in order to change its state.

  

  dan-searle

  authored and

  kateloschinina

  committed
  bfe622c

• Use classnames package to apply component classes. Ensure specified variant is supported.

  

  dan-searle

  authored and

  kateloschinina

  committed
  3bf8403

• Remove x-interaction dependency.

  

  dan-searle

  authored and

  kateloschinina

  committed
  48b3081

• Remove focus outline.

  

  dan-searle

  authored and

  kateloschinina

  committed
  1175d5a

• Only run bower install on prepare

  

  dan-searle

  authored and

  kateloschinina

  committed
  bb517bc

• don't display concept name in button text as a default

  

  fenglish

  authored and

  kateloschinina

  committed
  1c52108

• update snapshot tests

  

  fenglish

  authored and

  kateloschinina

  committed
  6d7de7c

• update node-sass

  

  fenglish

  authored and

  kateloschinina

  committed
  dbbb615

• useConceptNameAsButtonText => conceptNameAsButtonText

  

  fenglish

  authored and

  kateloschinina

  committed
  b1ab83e

• modify explanation of conceptNameAsButtonText

  

  fenglish

  authored and

  kateloschinina

  committed
  acc728c

• conceptNameAsButtonText as a knob not a separated story

  

  fenglish

  authored and

  kateloschinina

  committed
  8427d7c

• update snapshot tests

  

  fenglish

  authored and

  kateloschinina

  committed
  165f04c

• eslintignore tools/x-docs/static/**

  

  fenglish

  authored and

  kateloschinina

  committed
  fcdf405

• MyFT => myFT

  

  fenglish

  authored and

  kateloschinina

  committed
  493414b

• update snapshots

  

  fenglish

  authored and

  kateloschinina

  committed
  35fe36c

• add subjectName in event.detail

  

  fenglish

  authored and

  kateloschinina

  committed
  651eb75

• revert the commit to add subjectName in event.detail

  

  fenglish

  authored and

  kateloschinina

  committed
  7cfb279

• Modify the followed button text

  

  fenglish

  authored and

  kateloschinina

  committed
  86ac883

• Remove CSS comments

  Show description for 240650f
  

  dan-searle

  authored and

  kateloschinina

  committed
  240650f

• More useful readme

  

  dan-searle

  authored and

  kateloschinina

  committed
  b6e7832

• Not enough knobs to make it worth splitting them into groups.

  

  dan-searle

  authored and

  kateloschinina

  committed
  bfdbe7c

• Added onClick prop to X-Follow-Button

  

  Pavel Pichrt

  authored and

  kateloschinina

  committed
  8eec75d

• renamed onClick prop to onSubmit

  

  Pavel Pichrt

  authored and

  kateloschinina

  committed
  537f1f1

Commits on Nov 15, 2019

• Add x-follow-button to the new story format

  Show description for 53c1f5a
  kateloschinina

  committed
  53c1f5a

Commits on Nov 20, 2019

• Update snapshot

  kateloschinina

  committed
  e9338da

• Refactor x-follow-button storybook demo

  Show description for 21a1cc0
  kateloschinina

  committed
  21a1cc0

• Add tests

  Show description for 4b5843b
  kateloschinina

  committed
  4b5843b

Commits on Dec 4, 2019

• Use sass-loader in storybook webpack

  Show description for 4ae4119
  edds

  committed
  4ae4119

• Merge remote-tracking branch 'origin/master' into follow-button

  edds

  committed
  04d7890

• Update x-follow-button for origami major change

  Show description for f7474c7
  edds

  committed
  f7474c7