Fix automatic 'setIncludeHighlights' + handle errors from highlights token request (ELES-1237) #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egargan-ft
force-pushed
the
ELES-1237-fix-no-highlights-handling
branch
from
22998da to
30599fe
Compare
egargan-ft
changed the title
egargan-ft
force-pushed
the
ELES-1237-fix-no-highlights-handling
branch
from
30599fe to
9477365
Compare
ibrahim-mamdouh-ft
approved these changes
May 13, 2024
omarbassam88
approved these changes
May 13, 2024
meel-io
approved these changes
May 13, 2024
GlynnPhillips
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues related to the 'share with highlights' feature.
Currently, whenever a user selects "FT subscribers only", even if the article contains no highlights for the user, we still request a highlights access token.
Whenever the user selected "FT subscribers only", we
setIncludeHighlightsto the value of the "Anyone/FT subscribers only" switcher, which evaluates to true. This is an issue particularly when the article contains no highlights, as we don't display the 'Include Highlights' checkbox, but we're still setting it to true.This PR makes sure that we're only setting
includeHighlightswhen the user wishes to.It also adds some error handling to the code that requests the highlights token. Currently this endpoint does not return an error, but it soon will in an upcoming change to the Highlights backend, where the /create-token route will return 404 when the given article contains no highlights.