ESLint and Prettier in Harmony #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,6 @@ module.exports = ({tasks, prompt, addPrompt}) => ({ | |||
| async run(options) { | |||
| const port = parseInt(url.parse(openUrls.storybook).port, 10); | |||
| if(await tcpPortUsed.check(port)) { | |||
| console.log(); | |||
There was a problem hiding this comment.
this was there deliberately. i like some whitespace in my cli output 🙂
| @@ -16,13 +16,15 @@ export class InteractionClass extends Component { | |||
| // additional render will be scheduled. | |||
| Promise.resolve().then(() => { | |||
| this.setState({ [loading]: true }, () => { | |||
| /* eslint no-console:off */ | |||
| console.log('didsetloading', this.state[loading]); | |||
There was a problem hiding this comment.
these shouldn't be here but they're removed in #59
| @@ -62,9 +65,9 @@ export default class Search extends Component { | |||
| </div>; | |||
| } | |||
|
|
|||
| search = ev => { | |||
| search (ev) { | |||
There was a problem hiding this comment.
this will need to be bound now
packages/x-logo/index.js
Outdated
| @@ -72,25 +72,20 @@ const xPoints = ({x, y, width, height, thickness}) => { | |||
| } | |||
|
|
|||
| export default class XLogo extends Component { | |||
| static defaultProps = { | |||
There was a problem hiding this comment.
these missing default props are breaking the build
i-like-robots
force-pushed
the
matth/eslint
branch
from
e501c2e to
3ac1698
Compare
|
was just about to approve but noticed the base branch is |
i-like-robots
changed the base branch from
matth/migration-guide-tweaks
to
master
|
Woah, good spot! |
🐿 v2.10.0
🐿 v2.10.0
🐿 v2.10.0
🐿 v2.10.0
🐿 v2.10.0
🐿 v2.10.0
🐿 v2.10.0
i-like-robots
force-pushed
the
matth/eslint
branch
from
6835948 to
e858335
Compare
|
i mean, it had all the letters of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
I haven't enabled the prettier plugin because it needs to do quite a bit of work to make itself happy... one for another PR!
I've tried to fix the eslint errors where possible to do so.