Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on the new typescripts SDK to communicate with FiniteState #29

Merged
merged 13 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/linters/.eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ extends:
- eslint:recommended
- plugin:@typescript-eslint/eslint-recommended
- plugin:@typescript-eslint/recommended
- plugin:github/recommended
- plugin:jest/recommended

rules:
Expand All @@ -43,7 +42,6 @@ rules:
'import/no-namespace': 'off',
'no-console': 'off',
'no-unused-vars': 'off',
'prettier/prettier': 'error',
'semi': 'off',
'@typescript-eslint/array-type': 'error',
'@typescript-eslint/await-thenable': 'error',
Expand All @@ -53,7 +51,6 @@ rules:
['error', { 'accessibility': 'no-public' }],
'@typescript-eslint/explicit-function-return-type':
['error', { 'allowExpressions': true }],
'@typescript-eslint/func-call-spacing': ['error', 'never'],
'@typescript-eslint/no-array-constructor': 'error',
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-explicit-any': 'error',
Expand All @@ -76,8 +73,6 @@ rules:
'@typescript-eslint/promise-function-async': 'error',
'@typescript-eslint/require-array-sort-compare': 'error',
'@typescript-eslint/restrict-plus-operands': 'error',
'@typescript-eslint/semi': ['error', 'never'],
'@typescript-eslint/space-before-function-paren': 'off',
'@typescript-eslint/type-annotation-spacing': 'error',
'@typescript-eslint/unbound-method': 'error'
}
12 changes: 9 additions & 3 deletions .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,24 @@ jobs:
id: build
run: npm run bundle

# This will fail the workflow if the PR wasn't created by Dependabot.
# This will fail the workflow if the `dist/` directory is different than
# expected.
- name: Compare Directories
id: diff
run: |
if [ ! -d dist/ ]; then
echo "Expected dist/ directory does not exist. See status below:"
ls -la ./
exit 1
fi
if [ "$(git diff --ignore-space-at-eol --text dist/ | wc -l)" -gt "0" ]; then
echo "Detected uncommitted changes after build. See status below:"
git diff --ignore-space-at-eol --text dist/
exit 1
fi

# If `dist/` was different than expected, and this was not a Dependabot
# PR, upload the expected version as a workflow artifact.
# If `dist/` was different than expected, upload the expected version as a
# workflow artifact.
- if: ${{ failure() && steps.diff.outcome == 'failure' }}
name: Upload Artifact
id: upload
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,15 @@ jobs:

- name: Test
id: npm-ci-test
run: npm run ci-test
run: npm run ci-test -- --passWithNoTests

sbom_test_results:
name: GitHub Actions Test
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}

strategy:
matrix:
os: [windows-latest, ubuntu-latest]

steps:
- name: Checkout
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,14 @@ jobs:

- name: Lint Codebase
id: super-linter
uses: super-linter/super-linter/slim@v6
uses: super-linter/super-linter/slim@v7
env:
DEFAULT_BRANCH: main
FILTER_REGEX_EXCLUDE: dist/**/*
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TYPESCRIPT_DEFAULT_STYLE: prettier
VALIDATE_ALL_CODEBASE: true
VALIDATE_JAVASCRIPT_STANDARD: false
VALIDATE_JSCPD: false
VALIDATE_PYTHON_ISORT: false
VALIDATE_PYTHON_PYLINT: false
VALIDATE_PYTHON_FLAKE8: false
VALIDATE_TYPESCRIPT_STANDARD: false
VALIDATE_MARKDOWN: false
VALIDATE_MARKDOWN_PRETTIER: false
4 changes: 2 additions & 2 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright GitHub
Copyright Finite State

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ and Created By User. If you need to change these, you can provide IDs for them.

> [!WARNING]
>
> Warning: Ensure the GitHub Actions runner environment supports both Node.js
> and Python when running workflows that include JavaScript and Python scripts.
> Using an incompatible runner environment may result in errors or unexpected
> behavior during script execution.
> Warning: Ensure the GitHub Actions runner environment supports Node.js when
> running workflows that include JavaScript scripts. Using an incompatible
> runner environment may result in errors or unexpected behavior during script
> execution.
>
> To avoid issues, consider using a GitHub-hosted runner image like
> 'ubuntu-latest' or 'microsoft-latest' that comes pre-installed with both
> Node.js and Python required versions.
> 'ubuntu-latest' or 'microsoft-latest' that comes pre-installed with Node.js
> required version.

<!-- action-docs-description -->

Expand Down Expand Up @@ -113,7 +113,7 @@ optional fields.
**Example:**

```yaml
uses: FiniteStateInc/third-party-upload@v2.0.1
uses: FiniteStateInc/third-party-upload@v2.0.2
with:
finite-state-client-id: ${{ secrets.CLIENT_ID }}
finite-state-secret: ${{ secrets.CLIENT_SECRET }}
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
path: # The path to the scan results generated in the previous step

- name: SBOM analysis
uses: FiniteStateInc/third-party-upload@v2.0.1
uses: FiniteStateInc/third-party-upload@v2.0.2
id: third_party_upload
with:
finite-state-client-id: ${{ secrets.CLIENT_ID }}
Expand Down
17 changes: 0 additions & 17 deletions __tests__/index.test.ts

This file was deleted.

53 changes: 0 additions & 53 deletions __tests__/main.test.ts

This file was deleted.

76 changes: 0 additions & 76 deletions __tests__/python.test.ts

This file was deleted.

Loading
Loading