Add tokio taskname registration for use in tokio-console #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Finomnis
reviewed
Oct 29, 2024
|
We might have to think about how to update the CI. Should we test twice, once with and once without the feature? |
Yes, I think that makes sense to avoid code-rot. |
This uses the `tokio-unstable` feature that has to be enabled and also the runtime variable `RUSTFLAGS="--cfg tokio_unstable"` must be set to enable tokio taskname registration. See example program `tokio-console.rs` for usage.
hirschenberger
force-pushed
the
tokio-console
branch
from
a43abad to
03d584a
Compare
|
Will you look into that or do you need help? |
The CI? I'm not so familliar with Github CI, so help would be great. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 97.40% 97.46% +0.05%
==========================================
Files 14 15 +1
Lines 656 670 +14
Branches 656 670 +14
==========================================
+ Hits 639 653 +14
- Misses 0 1 +1
+ Partials 17 16 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Activating How does the output of |
|
@hirschenberger I did some refactoring; what's your opinion on the current state? (p.s. don't worry about the amount of commits, I'll squash anyway) |
|
@Finomnis Sorry for the late reply, I was busy the last days. You've been pretty productive. Looks good, I also thought about also naming the internal tasks (wait for signal and subsystem spawner). One little nitpick, it is a bit misleading that the spawn functions for the And I'm also not sure if my feature name |
You also named the wrong task :)
Propose something better :) my first guess was "spawn", but that collided with the function "spawn". Maybe "task", so you can do
Yah, maybe "tracing"? |
|
For the feature name how about |
It does more though; it enables Are you ok with simply |
I'm not really sure if it changes the tacing behaviour. I think this hurricane of logs comes from the tracing configuration in the example program. Maybe I did something wrong there and logged the messages that are meant for the tokio-console CLI to stdout. Unfortunately I have no time today to look into this. But I believe that's the reason. I have used tokio-console before without that amount of logs to stdout.
|
It seems to be the |
|
@hirschenberger Added some |
|
@hirschenberger Yah, I think I'm satisfied now. Would you mind reviewing it again as well? |
NICE |
Sure, but tomorrow. |
|
@Finomnis This looks pretty good. You put a lot of effort into my PR, nice work. I like the Looks fine for me |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
tokio-unstablefeature that has to be enabled and also the runtime variableRUSTFLAGS="--cfg tokio_unstable"must be set to enable tokio taskname registration.See example program
tokio-console.rsfor usage.fixes #87