Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize the differences between x/slashing and its upstream's #616

Closed
3 of 4 tasks
0Tech opened this issue Aug 1, 2022 · 0 comments · Fixed by #627
Closed
3 of 4 tasks

Minimize the differences between x/slashing and its upstream's #616

0Tech opened this issue Aug 1, 2022 · 0 comments · Fixed by #627
Assignees
@0Tech

Comments

@0Tech
Copy link
Collaborator

0Tech commented Aug 1, 2022

Summary

Minimize the differences between x/slashing and its upstream's, especially on /cosmos.slashing.v1beta1.ValidatorSigningInfo.

Problem Definition

Before cosmos/cosmos-sdk#10312 resolved, we should have introduced the additional field VoterSetCounter into ValidatorSigningInfo, because our consensus engine does not guarantee that every bonded validator participate in the vote every time (it's on purpose). Now the issue has been resolved, and we can revert the changes on proto, which minimizes the burden on tracking the upstream.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@0Tech 0Tech self-assigned this Aug 1, 2022
@0Tech 0Tech mentioned this issue Aug 4, 2022
Merged
5 tasks
da1suk8 pushed a commit that referenced this issue Dec 9, 2022
@assafmo @shiki-tak
Fix inconsistent return of contractAddress from keeper/init()
51db87b 
This will not affect functionality whatsoever, it just makes for a more consistent code, as discussed in issue #616.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0Tech 0Tech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: revert changes in x/slashing proto 0Tech/finschia-sdk
1 participant
@0Tech