Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the proof.proto path to third_party/proto/confio #1037

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

170210
Copy link
Contributor

@170210 170210 commented Jul 10, 2023

Description

This PR has following changes.

  • change the proof.proto path to third_party/proto/confio

closes: #767

Motivation and context

#767

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2023

CLA assistant check
All committers have signed the CLA.

@170210 170210 self-assigned this Jul 10, 2023
@170210 170210 requested review from tnasu, zemyblue, 0Tech and dudong2 July 10, 2023 08:39
@170210 170210 marked this pull request as ready for review July 10, 2023 08:39
@170210 170210 changed the title chore: change the proof.proto path to third_party/proto/confio refactor: change the proof.proto path to third_party/proto/confio Jul 11, 2023
@170210 170210 marked this pull request as draft July 11, 2023 01:20
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 force-pushed the feature/issue_767 branch from 0b588df to b508e4b Compare July 11, 2023 01:34
@170210 170210 marked this pull request as ready for review July 11, 2023 01:36
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog in CHANGELOGS.md

Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 added A: improvement Changes in existing functionality good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 11, 2023
@170210 170210 requested a review from zemyblue July 11, 2023 05:50
@ulbqb
Copy link
Member

ulbqb commented Jul 13, 2023

It seems like this PR is good because fixed path is the same path of cosmos-sdk. #651 is irrelevant as it is for ibc-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the proof.proto path to third_party/proto/confio.
5 participants