fix: add minted coins to balance in x/collection MsgMintFT #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
added
A: bug
0Tech
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.48.0-rcx #1105 +/- ##
==================================================
+ Coverage 69.70% 69.75% +0.05%
==================================================
Files 642 645 +3
Lines 67280 67468 +188
==================================================
+ Hits 46895 47061 +166
- Misses 18203 18219 +16
- Partials 2182 2188 +6
|
zemyblue
reviewed
Aug 31, 2023
|
I've checked the migration working as expected. Invariant relevant commits would be reverted as a result of an internal discussion. |
jaeseung-bae
reviewed
Sep 1, 2023
zemyblue
reviewed
Sep 1, 2023
zemyblue
reviewed
Sep 1, 2023
jaeseung-bae
approved these changes
Sep 1, 2023
zemyblue
approved these changes
Sep 1, 2023
zemyblue
added a commit
to zemyblue/finschia
that referenced
this pull request
Sep 1, 2023
…a-sdk#1105) Signed-off-by: zemyblue <zemyblue@gmail.com>
4 tasks
zemyblue
added a commit
to Finschia/finschia
that referenced
this pull request
Sep 1, 2023
…p up ostracon from `449aa3148b12` to `fc29846c918d` (#262) * deps: bump up finschia-sdk from `v0.48.0-rc2` to `20230830070349` and bump up ostracon from `449aa3148b12` to `fc29846c918d` Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * deps: bump up finschia-sdk to `0a27aef22921`. (apply Finschia/finschia-sdk#1105) Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update go.sum Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com>
5 tasks
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would fix accumulation logic of balance in MsgMintFT.
closes: #1104
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml