Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use go embed for swagger #1175

Merged
merged 2 commits into from
Nov 8, 2023
Merged

feat: use go embed for swagger #1175

merged 2 commits into from
Nov 8, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Nov 8, 2023

Description

closes: #XXXX

Replace deprecated package(statik) with built-in go embed for swagger.
I checked it worked well.

ref. cosmos/cosmos-sdk#15216

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality and removed A: feature New features labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1175 (731e0ee) into main (d232bd6) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files         646      646           
  Lines       67637    67637           
=======================================
  Hits        47152    47152           
  Misses      18284    18284           
  Partials     2201     2201           
Files Coverage Δ
simapp/app.go 81.56% <0.00%> (ø)

Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkxkd0159 tkxkd0159 merged commit 93fa67d into main Nov 8, 2023
42 of 43 checks passed
@tkxkd0159 tkxkd0159 deleted the replace-statik branch November 8, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: CI A: improvement Changes in existing functionality C:server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants