Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error handling for x/foundation migration #1295

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Mar 23, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae self-assigned this Mar 23, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2024

CLA assistant check
All committers have signed the CLA.

@jaeseung-bae jaeseung-bae added the C:x/foundation x/foundation module label Mar 23, 2024
@jaeseung-bae jaeseung-bae changed the base branch from main to release/v0.48.x March 23, 2024 02:19
@jaeseung-bae jaeseung-bae marked this pull request as ready for review March 23, 2024 02:21
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (66a0114) to head (69fe2cf).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.48.x    #1295   +/-   ##
================================================
  Coverage            69.78%   69.78%           
================================================
  Files                  646      646           
  Lines                67507    67507           
================================================
+ Hits                 47108    47109    +1     
+ Misses               18213    18212    -1     
  Partials              2186     2186           

see 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae changed the title fix: add error handling for migration(partial backport #1171) fix: add error handling for x/foundation migration Mar 23, 2024
zemyblue
zemyblue previously approved these changes Mar 23, 2024
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the recent change on CHANGELOG.md. However, it would be good to provide the PR number of the related fix in the PR description, because we want to know whether the fix had been applied into the main or not.

@0Tech 0Tech self-requested a review March 23, 2024 02:53
@jaeseung-bae jaeseung-bae merged commit 1f8e902 into Finschia:release/v0.48.x Mar 23, 2024
29 checks passed
@jaeseung-bae jaeseung-bae deleted the release/v0.48.x branch March 23, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants