Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update param validation to fail on nil dec (backport #1323) #1325

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1323 done by [Mergify](https://mergify.com).

* fix: update param validation to fail on nil dec

* chore: update changelog

(cherry picked from commit 55b6566)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Mar 28, 2024

Cherry-pick of 55b6566 has failed:

On branch mergify/bp/release/v0.48.x/pr-1323
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 55b6566bf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/mint/types/params.go
	modified:   x/slashing/types/params.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (69a3ec7) to head (696d83e).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.48.x    #1325      +/-   ##
===================================================
- Coverage            69.76%   69.74%   -0.03%     
===================================================
  Files                  646      646              
  Lines                67573    67594      +21     
===================================================
  Hits                 47142    47142              
- Misses               18242    18263      +21     
  Partials              2189     2189              
Files Coverage Δ
x/slashing/types/params.go 0.00% <0.00%> (ø)
x/mint/types/params.go 6.47% <0.00%> (-0.62%) ⬇️

@0Tech 0Tech self-assigned this Mar 29, 2024
@0Tech 0Tech added A: bug Something isn't working C:x/slashing C:x/mint and removed conflicts labels Mar 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit f5275d7 into release/v0.48.x Mar 29, 2024
28 of 29 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1323 branch March 29, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/mint C:x/slashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants