Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add CLI, gRPC, MsgServer tests (backport #1405) #1430

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2024

Description

closes: #XXXX

Test coverage reached over 80%

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1405 done by [Mergify](https://mergify.com).

* Add global test codec

* Add TransferTxCmd test

* Add the remaining tx cli tests

* Add cli query test

* Add fbridge auth test case

* Add grpc-query test

* Add msg server tests

* Add type tests

* Add CHANGELOG

(cherry picked from commit 97219d5)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from tkxkd0159 as a code owner June 25, 2024 12:52
@mergify mergify bot added the conflicts label Jun 25, 2024
Copy link
Contributor Author

mergify bot commented Jun 25, 2024

Cherry-pick of 97219d5 has failed:

On branch mergify/bp/release/v0.49.x/pr-1405
Your branch is up to date with 'origin/release/v0.49.x'.

You are currently cherry-picking commit 97219d5ee.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   client/tendermint.go
	modified:   init_node.sh
	new file:   testutil/cli/tm_mocks.go
	new file:   types/module/testutil/codec.go
	modified:   x/fbridge/client/cli/query.go
	new file:   x/fbridge/client/cli/query_test.go
	modified:   x/fbridge/client/cli/tx.go
	new file:   x/fbridge/client/cli/tx_test.go
	new file:   x/fbridge/keeper/abci_test.go
	modified:   x/fbridge/keeper/auth.go
	modified:   x/fbridge/keeper/auth_test.go
	new file:   x/fbridge/keeper/genesis_test.go
	new file:   x/fbridge/keeper/grpc_query_test.go
	new file:   x/fbridge/keeper/msg_server_test.go
	new file:   x/fbridge/types/fbridge_test.go
	new file:   x/fbridge/types/keys_test.go
	modified:   x/fbridge/types/params_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@tkxkd0159 tkxkd0159 self-assigned this Jun 25, 2024
@tkxkd0159 tkxkd0159 changed the title test: add CLI, gRPC, MsgServer tests (backport #1405) test: Add CLI, gRPC, MsgServer tests (backport #1405) Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 13.72549% with 44 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (8c5ab7e) to head (fd51ac6).
Report is 1 commits behind head on release/v0.49.x.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1430      +/-   ##
===================================================
+ Coverage            68.75%   69.68%   +0.93%     
===================================================
  Files                  754      756       +2     
  Lines                75837    75883      +46     
===================================================
+ Hits                 52139    52882     +743     
+ Misses               21042    20310     -732     
- Partials              2656     2691      +35     
Files Coverage Δ
x/fbridge/client/cli/query.go 72.38% <100.00%> (+72.38%) ⬆️
x/fbridge/client/cli/tx.go 92.00% <100.00%> (+92.00%) ⬆️
x/fbridge/keeper/auth.go 86.61% <0.00%> (+30.96%) ⬆️
testutil/cli/tm_mocks.go 0.00% <0.00%> (ø)
types/module/testutil/codec.go 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@tkxkd0159 tkxkd0159 merged commit 48480c1 into release/v0.49.x Jun 26, 2024
28 of 29 checks passed
@tkxkd0159 tkxkd0159 deleted the mergify/bp/release/v0.49.x/pr-1405 branch June 26, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants