Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix goreleaser config #1431

Merged
merged 6 commits into from
Jul 11, 2024
Merged

bug: Fix goreleaser config #1431

merged 6 commits into from
Jul 11, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Jun 25, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog

@tkxkd0159 tkxkd0159 added A: bug Something isn't working A: CI backport/v0.49.x labels Jun 26, 2024
@tkxkd0159 tkxkd0159 requested a review from zemyblue June 26, 2024 02:08
jaeseung-bae
jaeseung-bae previously approved these changes Jun 26, 2024
@tkxkd0159 tkxkd0159 merged commit 8e266d8 into main Jul 11, 2024
33 checks passed
@tkxkd0159 tkxkd0159 deleted the fix-goreleaser-bug branch July 11, 2024 05:16
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
* bug: Fix goreleaser config

* Remove hardcoding var

* Add CHANGELOG

* Modify release config

* Exclude irrelevant commit and include missing commit

(cherry picked from commit 8e266d8)

# Conflicts:
#	.github/workflows/tag.yml
#	CHANGELOG.md
#	Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working A: CI backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants