Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build properly when using libsecp256k1 #195

Merged

Conversation

whylee259
Copy link
Contributor

Description

  • fix the receiver of function VerifySignature
  • update the ostracon version which has no effect for the tag of libsecp256k1
  • update makefile

related to: #173
closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@whylee259 whylee259 self-assigned this May 12, 2021
Makefile Outdated Show resolved Hide resolved
When LBM_BUILD_OPTIONS has no DB options and only has libsecp256k1, goleveldb will be selected by default.
The previous commit has a bug for that.
@whylee259 whylee259 force-pushed the whylee/v2/fix/build-properly-when-using-libsecp256k1 branch from 6985d96 to 8a27f51 Compare May 13, 2021 02:57
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #195 (6f42a29) into v2/develop (8353d2a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v2/develop     #195   +/-   ##
===========================================
  Coverage       53.09%   53.09%           
===========================================
  Files             688      688           
  Lines           49057    49057           
===========================================
+ Hits            26046    26048    +2     
+ Misses          20116    20115    -1     
+ Partials         2895     2894    -1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 86.52% <0.00%> (+0.37%) ⬆️

@whylee259 whylee259 merged commit 43e2b66 into v2/develop May 13, 2021
@whylee259 whylee259 deleted the whylee/v2/fix/build-properly-when-using-libsecp256k1 branch May 13, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants