test: enable sim test, race test #326
Conversation
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage ? 53.16%
=======================================
Files ? 642
Lines ? 67253
Branches ? 0
=======================================
Hits ? 35757
Misses ? 28551
Partials ? 2945 |
|
Looking good to me, other than lint failure. |
| @@ -361,7 +361,7 @@ func (app *BaseApp) setCheckState(header ocproto.Header) { | |||
|
|
|||
| app.checkState = &state{ | |||
| ms: ms, | |||
| ctx: ctx.WithConsensusParams(app.GetConsensusParams(ctx)), | |||
| ctx: ctx, | |||
There was a problem hiding this comment.
This modification reverts a part of #142.
The previous code causes sim test failure.
We must not call app.GetConsensusParams() while we initialize checkState because app.GetConsensusParams() caches nil value in cache store.
Normally, this is not a problem, but this is a problem because simulation tests do deliverTx immediately without checkTx.
| # - name: Run cosmovisor tests | ||
| # run: cd cosmovisor; make | ||
| # if: env.GIT_DIFF | ||
| # TODO: disable test-cosmovisor; this test uses uploaded binary(cosmos-sdk) |
There was a problem hiding this comment.
In order to enable this, research on test-cosmovisor is needed. We have to do this as a separate task.
.github/workflows/sims.yml
Outdated
| @@ -142,8 +141,9 @@ jobs: | |||
| run: go version | |||
| - uses: technote-space/get-diff-action@v5.0.1 | |||
| with: | |||
| SUFFIX_FILTER: | | |||
| PATTERNSR: | | |||
There was a problem hiding this comment.
I found a typo. I'll fix it in next PR or next commit for a comment.
x/auth/types/account.go
Outdated
| PubType byte `json:"pub_type"` | ||
| PubKey []byte `json:"pub_key"` |
There was a problem hiding this comment.
How about grouping the pubkey properties?
e.g.
{
"address": ...,
"sequence": ...,
"pub_key": {
"type":...,
"key":...,
}
}
Description
test.ymlgithub actionGetConsensusParams()while initializingcheckState. Reverts a part of feat: implementvalidateGasWanted()(#48) #142.BaseAccountmarshal/unmarshalBaseVestingAccount,ContinuousVestingAccount,PeriodicVestingAccountandDelayedVestingAccountmarshalJSONPB/unmarshalJSONPBx/distribution/keeper/hooks.goaddress conversion bugx/distribution/types/keys.gokey prefix bugSets and noWritemake the mismatch between db store and cache. Reverts chore: caching paramset #198x/slashing/keeper/hooks.goaddress conversion bugSUFFIX_FILTERfromsims.ymldocs/core/proto-docs.mdcloses: #318
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes