Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefetch functionality #596

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Conversation

torao
Copy link
Contributor

@torao torao commented Jul 14, 2022

Description

This PR removes the following features added in LBM SDK based on the result of #582 and revets to the same implementation as Cosmos SDK.

  • Prefetch behavior on gRPC endpoint and storage layer
  • Parallel writes

However, the following features are corrections that should be made in #595, so this PR does nothing.

  • Remove CacheManager
  • Revert back to fastcache

closes: #582

@torao torao self-assigned this Jul 14, 2022
@torao torao requested review from dudong2, tnasu and zemyblue July 14, 2022 07:05
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #596 (09474e0) into main (728aea5) will increase coverage by 3.05%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   57.53%   60.59%   +3.05%     
==========================================
  Files         796      814      +18     
  Lines       87526    94798    +7272     
==========================================
+ Hits        50362    57446    +7084     
- Misses      34025    34098      +73     
- Partials     3139     3254     +115     
Impacted Files Coverage Δ
baseapp/abci.go 61.82% <ø> (-0.24%) ⬇️
baseapp/grpcrouter.go 85.93% <ø> (-1.74%) ⬇️
server/mock/store.go 21.42% <ø> (-1.58%) ⬇️
simapp/ante_handler.go 0.00% <0.00%> (ø)
store/cachekv/store.go 87.83% <ø> (-0.48%) ⬇️
store/cachemulti/store.go 9.52% <0.00%> (+1.19%) ⬆️
store/dbadapter/store.go 100.00% <ø> (+7.31%) ⬆️
store/gaskv/store.go 100.00% <ø> (ø)
store/iavl/store.go 61.66% <0.00%> (+1.34%) ⬆️
store/iavl/tree.go 89.65% <ø> (ø)
... and 55 more

@torao torao marked this pull request as ready for review July 19, 2022 05:23
@torao torao merged commit 1bc3aac into Finschia:main Jul 19, 2022
torao added a commit to torao/finschia-sdk that referenced this pull request Jul 19, 2022
* remove prefetch functionality and write by multi-threading

* apply goimports

* fix a few trivial diff
ulbqb added a commit to ulbqb/finschia-sdk that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation of Prefetching changes
4 participants