-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update x/foundation params #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 61.96% 62.00% +0.04%
==========================================
Files 874 874
Lines 98797 98608 -189
==========================================
- Hits 61215 61139 -76
+ Misses 33938 33857 -81
+ Partials 3644 3612 -32
|
0Tech
force-pushed
the
foundation_params
branch
from
October 11, 2022 05:55
b0c68d2
to
842efd1
Compare
0Tech
commented
Oct 11, 2022
dudong2
reviewed
Oct 12, 2022
0Tech
force-pushed
the
foundation_params
branch
from
October 12, 2022 12:45
86e4df3
to
43fdab2
Compare
0Tech
force-pushed
the
foundation_params
branch
from
October 13, 2022 04:47
43fdab2
to
5a28fdd
Compare
zemyblue
reviewed
Oct 14, 2022
zemyblue
reviewed
Oct 14, 2022
This reverts commit ded8679.
Please update lbm also. |
Add "is" in front of the variable `outsourcing`.
zemyblue
approved these changes
Oct 17, 2022
5 tasks
dudong2
approved these changes
Oct 18, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would:
Params
.Enabled
in favor of the fine-grained alternative.CensoredMsgTypeUrls
which contains the message type urls of the messages under the censorship.FoundationInfo
must be supplied, and its contents must be valid.CreateValidatorAuthorization
s.UpdateOperator()
.MustAccAddressFromBech32()
.Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml