Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prune stale x/foundation proposals at voting period end #730

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 18, 2022

Description

The specification #721 says aborted and withdrawn proposals must be pruned at their voting period end. This patch addresses the difference in logic from the documentation's.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Oct 18, 2022
@0Tech 0Tech self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #730 (abd7e43) into main (5ed82db) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   61.96%   61.95%   -0.02%     
==========================================
  Files         877      877              
  Lines       98764    98819      +55     
==========================================
+ Hits        61200    61219      +19     
- Misses      33955    33997      +42     
+ Partials     3609     3603       -6     
Impacted Files Coverage Δ
x/foundation/client/testutil/query.go 100.00% <100.00%> (ø)
x/foundation/keeper/proposal.go 83.70% <100.00%> (+0.76%) ⬆️
x/token/validation.go 70.90% <0.00%> (-20.00%) ⬇️
x/token/msgs.go 28.42% <0.00%> (-4.07%) ⬇️
x/collection/msgs.go 39.62% <0.00%> (-3.34%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 18, 2022 06:57
@0Tech 0Tech merged commit b13ab12 into Finschia:main Oct 19, 2022
@0Tech 0Tech deleted the foundation_pruning branch October 19, 2022 07:45
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants