-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove time-based upgrade #889
Merged
dudong2
merged 8 commits into
Finschia:main
from
dudong2:dudong2/feat/remove-time-based-upgrade
Feb 10, 2023
Merged
feat: remove time-based upgrade #889
dudong2
merged 8 commits into
Finschia:main
from
dudong2:dudong2/feat/remove-time-based-upgrade
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 62.31% 62.31% -0.01%
==========================================
Files 652 652
Lines 79493 79480 -13
==========================================
- Hits 49534 49524 -10
+ Misses 27279 27277 -2
+ Partials 2680 2679 -1
|
dudong2
requested review from
0Tech,
jaeseung-bae,
loin3,
tkxkd0159 and
zemyblue
February 9, 2023 10:15
tkxkd0159
reviewed
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This binary(x/upgrade/types/__debug_bin
) is attached by accident. Is's it?
jaeseung-bae
approved these changes
Feb 10, 2023
zemyblue
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Time based upgrade feature is removed from cosmos-sdk pr #8849 of cosmos-sdk. It reflects the work that was missing in the previous bump up process.
I'm not modified upgrade.proto in the pr, because the time variable in upgrade.proto is reverted on cosmos-sdk pr #9534.
closes: #787
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml