deprecate block mode in proto #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
- Coverage 62.34% 62.34% -0.01%
==========================================
Files 653 653
Lines 79485 79485
==========================================
- Hits 49558 49557 -1
- Misses 27248 27249 +1
Partials 2679 2679
|
loin3
requested review from
zemyblue,
0Tech,
dudong2,
jaeseung-bae and
tkxkd0159
and removed request for
zemyblue
tkxkd0159
approved these changes
Mar 7, 2023
jaeseung-bae
approved these changes
Mar 8, 2023
zemyblue
approved these changes
Mar 9, 2023
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Mar 17, 2023
* feat: deprecate block mode in proto * add changelog (cherry picked from commit b626dec)
5 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmos-sdk decided to delete block mode when broadcast from v0.47.x through cosmos/cosmos-sdk#12659.
test codes using CLI are also using block mode when broadcasting, lots of changes would be occurred if we delete block mode in lbm-sdk.
so in this PR, only proto file is changed to block mode marked as deprecated.
Description
closes: #902
Motivation and context
How has this been tested?
Screenshots (if appropriate):
block mode will be marked as deprecated when using in other projectChecklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml