chore: fix Makefile for format and execute make format

[loloicci]

Description

This PR fixes make format command and executes it.

This PR replaces the lint tool for importing orders with goimports-reviser (https://github.com/incu6us/goimports-reviser). This makes it unify how to order imports regardless of how programmers separate imports into some blocks.

Motivation and context

Without this PR, make format formats client/docs/statik/statik.go and it causes a CI error.

Without this PR, how to separate format blocks is on how programmers write them.

How has this been tested?

Not needed.

Checklist:

• I followed the contributing guidelines and code of conduct.
• I have added a relevant changelog to CHANGELOG.md
• I have added tests to cover my changes. (not needed)
• I have updated the documentation accordingly. (not needed)

[codecov]

Codecov Report

Merging #230 (2773527) into main (880ef9d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files           8        8           
  Lines        1068     1068           
=======================================
  Hits          480      480           
  Misses        570      570           
  Partials       18       18           

Files Changed	Coverage Δ
ante/ante.go	0.00% <ø> (ø)
app/app.go	84.12% <ø> (ø)
cmd/fnsad/cmd/root.go	12.91% <ø> (ø)

[zemyblue]

To use make format, we need to install goimports. So how about adding golang.org/x/tools in go.mod as using ggo install golang.org/x/tools/cmd/goimports?

[loloicci]

To use make format, we need to install goimports. So how about adding golang.org/x/tools in go.mod as using ggo install golang.org/x/tools/cmd/goimports?

I think it is not needed because goimports is not needed to build or install fnsa.
And, I want to leave it as another issue if needed. This is not in this PR's scope.

[zemyblue]

To use make format, we need to install goimports. So how about adding golang.org/x/tools in go.mod as using ggo install golang.org/x/tools/cmd/goimports?

I think it is not needed because goimports is not needed to build or install fnsa. And, I want to leave it as another issue if needed. This is not in this PR's scope.

Ok, I understand. Thank you.

[zemyblue]

I had mistaken at #221. We can fix this bug by adding "" to the next line.

finschia/Makefile

Line 119 in 225b581

-X github.com/Finschia/finschia-sdk/version.BuildTags=$(build_tags_comma_sep) \

This is a rollback in this changes.
https://github.com/Finschia/finschia/pull/221/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L118-R119

[zemyblue]

Do you know the import path sorting rule?

[loloicci]

Do you know the import path sorting rule?

It uses goimports, but I don't know in what order goimports sort imports, sorry.

[zemyblue]

Do you know the import path sorting rule?

It uses goimports, but I don't know in what order goimports sort imports, sorry.

I think this sorting rule is difference with ours. So this may make conflict with others.
Finschia/ostracon#559 (review)

How do you think about this?

[loloicci]

Do you know the import path sorting rule?

It uses goimports, but I don't know in what order goimports sort imports, sorry.

I think this sorting rule is difference with ours. So this may make conflict with others.
Finschia/ostracon#559 (review)

How do you think about this?

How about replacing -local github.com/Finschia/finschia-sdk with -local github.com/Finschia

-local means

-local string
put imports beginning with this string after 3rd-party packages; comma-separated list

And, executed example is loloicci@6f2afa6

[loloicci]

I replaced the lint tool for import with goimports-reviser. This enables to unify import block format.

[170210]

Could jobs in workflow be combined into one? And if you want to use cache for next time, it maybe need reverse the order of "install tools" and "actions/cache".

[170210]

LGTM