Align with ValidatorSet on PruneStates() (#525)

* Align with ValidatorSet on `PruneStates()` * Revert removing defer in the loop
Finschia · Dec 9, 2022 · 7ba5191 · 7ba5191
1 parent a25ada8
commit 7ba5191
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/state/store.go b/state/store.go
@@ -311,6 +311,14 @@ func (store dbStore) PruneStates(from int64, to int64) error {
 			if err != nil {
 				return err
 			}
+			err = batch.Delete(calcVoterParamsKey(h))
+			if err != nil {
+				return err
+			}
+			err = batch.Delete(calcProofHashKey(h))
+			if err != nil {
+				return err
+			}
 		}
 
 		if keepParams[h] {
@@ -343,16 +351,6 @@ func (store dbStore) PruneStates(from int64, to int64) error {
 			}
 		}
 
-		err = batch.Delete(calcVoterParamsKey(h))
-		if err != nil {
-			return err
-		}
-
-		err = batch.Delete(calcProofHashKey(h))
-		if err != nil {
-			return err
-		}
-
 		err = batch.Delete(calcABCIResponsesKey(h))
 		if err != nil {
 			return err

diff --git a/state/store_test.go b/state/store_test.go
@@ -299,6 +299,15 @@ func TestPruneStates(t *testing.T) {
 					require.Error(t, err, "abci height %v", h)
 					require.Equal(t, sm.ErrNoABCIResponsesForHeight{Height: h}, err)
 				}
+				_, voters, voterParams, proof, err := stateStore.LoadVoters(h, nil)
+				if expectVals[h] {
+					require.NotNil(t, voters)
+					require.NotNil(t, voterParams)
+					require.NotNil(t, proof)
+				} else {
+					require.Error(t, err, "validators height %v", h)
+					require.Equal(t, sm.ErrNoValSetForHeight{Height: h}, err)
+				}
 			}
 		})
 	}