Skip to content

Commit

Permalink
mempool/rpc: log grooming (bp #6201) (#6203)
Browse files Browse the repository at this point in the history
  • Loading branch information
tnasu committed Dec 8, 2021
1 parent b22dbc3 commit 9243a45
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
3 changes: 2 additions & 1 deletion rpc/jsonrpc/server/http_json_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,16 @@ func makeJSONRPCHandler(funcMap map[string]*RPCFunc, logger log.Logger) http.Han
}
args = append(args, fnArgs...)
}

returns := rpcFunc.f.Call(args)
logger.Debug("HTTPJSONRPC", "method", request.Method, "args", args, "returns", returns)
result, err := unreflectResult(returns)
if err != nil {
responses = append(responses, types.RPCInternalError(request.ID, err))
continue
}
responses = append(responses, types.NewRPCSuccessResponse(request.ID, result))
}

if len(responses) > 0 {
WriteRPCResponseHTTP(w, responses...)
}
Expand Down
8 changes: 5 additions & 3 deletions rpc/jsonrpc/server/http_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,11 @@ func RecoverAndLogHandler(handler http.Handler, logger log.Logger) http.Handler
if rww.Status == -1 {
rww.Status = 200
}
logger.Info("Served RPC HTTP response",
"method", r.Method, "url", r.URL,
"status", rww.Status, "duration", durationMS,
logger.Debug("served RPC HTTP response",
"method", r.Method,
"url", r.URL,
"status", rww.Status,
"duration", durationMS,
"remoteAddr", r.RemoteAddr,
)
}()
Expand Down
8 changes: 6 additions & 2 deletions test/e2e/runner/rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,22 @@ func waitForNode(node *e2e.Node, height int64, timeout time.Duration) (*rpctypes

// waitForAllNodes waits for all nodes to become available and catch up to the given block height.
func waitForAllNodes(testnet *e2e.Testnet, height int64, timeout time.Duration) (int64, error) {
lastHeight := int64(0)
var lastHeight int64

for _, node := range testnet.Nodes {
if node.Mode == e2e.ModeSeed {
continue
}
status, err := waitForNode(node, height, 20*time.Second)

status, err := waitForNode(node, height, timeout)
if err != nil {
return 0, err
}

if status.SyncInfo.LatestBlockHeight > lastHeight {
lastHeight = status.SyncInfo.LatestBlockHeight
}
}

return lastHeight, nil
}

0 comments on commit 9243a45

Please sign in to comment.