Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more test cases verifying voter sampling #105

Merged
merged 17 commits into from
Jul 20, 2020
Merged

test: add more test cases verifying voter sampling #105

merged 17 commits into from
Jul 20, 2020

Conversation

egonspace
Copy link
Contributor

Add more test case verifying voter sampling

  • non-voter votes: consensus/TestStateBadVoterWithSelectedVoter
  • voter election in a situation where the validator set changes: consensus/TestStateAllVoterToSelectedVoter

Description

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@egonspace egonspace requested review from torao and zemyblue July 13, 2020 06:36
@egonspace egonspace self-assigned this Jul 13, 2020
@egonspace egonspace added C: test Classification: Add test case WIP labels Jul 13, 2020
@egonspace egonspace added this to the Change reward distribution milestone Jul 13, 2020
@egonspace egonspace removed the WIP label Jul 16, 2020
torao
torao approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 89f1168 into develop Jul 20, 2020
@egonspace egonspace mentioned this pull request Aug 2, 2020
Merged
5 tasks
@egonspace egonspace deleted the test/voter_selection branch December 10, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@egonspace egonspace

Labels
C: test Classification: Add test case
Projects
None yet
Milestone
Change reward distribution
Development

Successfully merging this pull request may close these issues.
3 participants
@egonspace @torao @zemyblue