-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main patch tm-v0.34.11 #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 64.31% 64.45% +0.13%
==========================================
Files 274 274
Lines 30692 30698 +6
==========================================
+ Hits 19741 19785 +44
+ Misses 9188 9144 -44
- Partials 1763 1769 +6
|
tnasu
force-pushed
the
main-patch-tm-v0.34.11
branch
from
January 11, 2022 04:17
fee0a97
to
74c6973
Compare
(cherry picked from commit d36a5905a67db1ed7afb09f371b3ea3910afb6eb) Co-authored-by: Sam Kleinman <garen@tychoish.com>
tnasu
force-pushed
the
main-patch-tm-v0.34.11
branch
from
January 12, 2022 05:36
74c6973
to
d13c936
Compare
tnasu
force-pushed
the
main-patch-tm-v0.34.11
branch
from
January 14, 2022 05:25
512d4c8
to
48a55ae
Compare
…ular file (backport: #6428) (#6436) Co-authored-by: Callum Waters <cmwaters19@gmail.com>
…king if regular file (backport: #6428) (#6436)`
… (backport #6522) (#6528) * p2p/conn: check for channel id overflow before processing receive msg (#6522) Per tendermint spec, each Channel has a globally unique byte id, which is mapped to uint8 in Go. However, the proto PacketMsg.ChannelID field is declared as int32, and when receive the packet, we cast it to a byte without checking for possible overflow. That leads to a malform packet with invalid channel id is sent successfully. To fix it, we just add a check for possible overflow, and return invalid channel id error. Fixed #6521 (cherry picked from commit 1f46a4c90e268def505037a5d42627942f605ef4)
* state sync: tune request timeout and chunkers (#6566) (cherry picked from commit 7d961b55b2132d53ccf7ee8d6c86b84fc7fc9ddc) * fix build * fix config * fix config Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
tnasu
force-pushed
the
main-patch-tm-v0.34.11
branch
from
January 18, 2022 09:28
0c43da6
to
4f2fe0f
Compare
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Kynea0b
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Jan 19, 2022
torao
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kynea0b
reviewed
Jan 20, 2022
Kynea0b
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.34.11
STATUS: commit hash