Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main patch tm-v0.34.13 #364

Merged
merged 9 commits into from
Feb 10, 2022
Merged

Main patch tm-v0.34.13 #364

merged 9 commits into from
Feb 10, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jan 21, 2022

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #364 (2b66ec9) into main (7320ceb) will increase coverage by 0.16%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   64.47%   64.64%   +0.16%     
==========================================
  Files         274      277       +3     
  Lines       30698    30925     +227     
==========================================
+ Hits        19792    19990     +198     
- Misses       9133     9148      +15     
- Partials     1773     1787      +14     
Impacted Files Coverage Δ
config/config.go 80.75% <ø> (ø)
config/toml.go 68.00% <ø> (ø)
light/rpc/client.go 14.67% <0.00%> (-0.10%) ⬇️
proxy/client.go 25.80% <0.00%> (ø)
rpc/core/abci.go 0.00% <ø> (ø)
rpc/core/routes.go 0.00% <ø> (ø)
rpc/core/types/responses.go 36.36% <ø> (ø)
rpc/jsonrpc/client/test_util.go 0.00% <0.00%> (ø)
statesync/reactor.go 72.25% <ø> (+0.65%) ⬆️
statesync/stateprovider.go 0.00% <ø> (ø)
... and 37 more

@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jan 25, 2022
tnasu and others added 8 commits January 25, 2022 13:03
(cherry picked from commit a4cc8317da47ba92d1a97460a953d0e687a46cfb)

Co-authored-by: Sam Kleinman <garen@tychoish.com>
I realized after my last commit that my change made a following line of code a bit redundant.

(alternatively my last change was redunadnt to the existing code.)

I took this oppertunity to make some minor cleanups and logging changes to the node changes which I hope will make tests a bit more clear.

(cherry picked from commit a374f74f7c914a3c7640694ae80c33bf74e05688)

Co-authored-by: Sam Kleinman <garen@tychoish.com>
Issues reported in Osmosis, where the message is extremely long. Also, there is absolutely no reason to log the message IMO. If we must, we can make the message log DEBUG.

(cherry picked from commit 58a6cfff9a3e370e1bb5eabfd86091e0b1186a22)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
…6881)

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
This change backports the PostgreSQL indexing sink, addressing part of #6828.

Development on the main branch has diverged substantially since the v0.34.x
release. It includes package moves, breaking API and protobuf schema changes,
and new APIs, all of which together have a large footprint on the mapping
between the implementation at tip and the v0.34 release branch.

To avoid the need to retrofit all of those improvements, this change works by
injecting the new indexing sink into the existing (v0.34) indexing interfaces
by delegation. This means the backport does _not_ pull in all the newer APIs
for event handling, and thus has minimal impact on existing code written
against the v0.34 package structure.

This change includes the test for the `psql` implementation, and thus updates
some Go module dependencies. Because it does not interact with any other types,
however, I did not add any unit tests to other packages in this change.

Related changes:
 * Update module dependencies for psql backport.
 * Update test data to be type-compatible with the old protobuf types.
 * Add config settings for the PostgreSQL indexer.
 * Clean up some linter settings.
 * Hook up the psql indexer in the node main.

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
@tnasu tnasu force-pushed the main-patch-tm-v0.34.13 branch from afff36b to 1d42c3f Compare January 27, 2022 03:40
@tnasu tnasu force-pushed the main-patch-tm-v0.34.13 branch from 1d42c3f to 2b66ec9 Compare January 27, 2022 03:51
@tnasu tnasu marked this pull request as ready for review January 27, 2022 04:43
@tnasu tnasu requested review from Kynea0b and torao as code owners January 27, 2022 04:43
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit a9a7629 into Finschia:main Feb 10, 2022
@tnasu tnasu deleted the main-patch-tm-v0.34.13 branch February 28, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants