-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main patch tm-v0.34.13 #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 64.47% 64.64% +0.16%
==========================================
Files 274 277 +3
Lines 30698 30925 +227
==========================================
+ Hits 19792 19990 +198
- Misses 9133 9148 +15
- Partials 1773 1787 +14
|
Kynea0b
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Jan 25, 2022
(cherry picked from commit a4cc8317da47ba92d1a97460a953d0e687a46cfb) Co-authored-by: Sam Kleinman <garen@tychoish.com>
I realized after my last commit that my change made a following line of code a bit redundant. (alternatively my last change was redunadnt to the existing code.) I took this oppertunity to make some minor cleanups and logging changes to the node changes which I hope will make tests a bit more clear. (cherry picked from commit a374f74f7c914a3c7640694ae80c33bf74e05688) Co-authored-by: Sam Kleinman <garen@tychoish.com>
Issues reported in Osmosis, where the message is extremely long. Also, there is absolutely no reason to log the message IMO. If we must, we can make the message log DEBUG. (cherry picked from commit 58a6cfff9a3e370e1bb5eabfd86091e0b1186a22) Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
…6881) Co-authored-by: Callum Waters <cmwaters19@gmail.com>
… (backport) (#6881)`
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
This change backports the PostgreSQL indexing sink, addressing part of #6828. Development on the main branch has diverged substantially since the v0.34.x release. It includes package moves, breaking API and protobuf schema changes, and new APIs, all of which together have a large footprint on the mapping between the implementation at tip and the v0.34 release branch. To avoid the need to retrofit all of those improvements, this change works by injecting the new indexing sink into the existing (v0.34) indexing interfaces by delegation. This means the backport does _not_ pull in all the newer APIs for event handling, and thus has minimal impact on existing code written against the v0.34 package structure. This change includes the test for the `psql` implementation, and thus updates some Go module dependencies. Because it does not interact with any other types, however, I did not add any unit tests to other packages in this change. Related changes: * Update module dependencies for psql backport. * Update test data to be type-compatible with the old protobuf types. * Add config settings for the PostgreSQL indexer. * Clean up some linter settings. * Hook up the psql indexer in the node main. Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
tnasu
force-pushed
the
main-patch-tm-v0.34.13
branch
from
January 27, 2022 03:40
afff36b
to
1d42c3f
Compare
tnasu
force-pushed
the
main-patch-tm-v0.34.13
branch
from
January 27, 2022 03:51
1d42c3f
to
2b66ec9
Compare
torao
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kynea0b
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.34.13
STATUS: commit hash