Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checking tx with txsMap for fixing the inconsistency between mem.txs and mem.txsMap #404

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Improve checking tx with txsMap for fixing the inconsistency between mem.txs and mem.txsMap #404

merged 1 commit into from
Apr 15, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Apr 14, 2022 •
edited
Loading

Description

Apply to check tx with mem.txsMap on mem.prepareCheckTx

Closes: #395

@tnasu tnasu force-pushed the main-fix-mempool branch 3 times, most recently from 39c17e9 to 31bd498 Compare April 14, 2022 10:52
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #404 (c78ead8) into main (9615276) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   65.16%   65.19%   +0.03%     
==========================================
  Files         277      277              
  Lines       37832    37836       +4     
==========================================
+ Hits        24653    24668      +15     
+ Misses      11373    11359      -14     
- Partials     1806     1809       +3
Impacted Files Coverage Δ
mempool/errors.go 25.00% <ø> (ø)
mempool/clist_mempool.go 82.41% <100.00%> (-0.68%) ⬇️
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
consensus/reactor.go 74.49% <0.00%> (-0.63%) ⬇️
light/client.go 61.61% <0.00%> (-0.45%) ⬇️
mempool/reactor.go 79.67% <0.00%> (ø)
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
consensus/state.go 73.85% <0.00%> (+0.52%) ⬆️
p2p/switch.go 66.52% <0.00%> (+0.61%) ⬆️
... and 3 more

@tnasu tnasu force-pushed the main-fix-mempool branch from 31bd498 to 3578a09 Compare April 14, 2022 11:07
@tnasu tnasu force-pushed the main-fix-mempool branch from 3578a09 to c78ead8 Compare April 14, 2022 13:30
@tnasu tnasu changed the title Improve checking tx in txsMap Improve checking tx in txsMap for fixing the inconsistency between mem.txs and mem.txsMap Apr 14, 2022
@tnasu tnasu changed the title Improve checking tx in txsMap for fixing the inconsistency between mem.txs and mem.txsMap Improve checking tx with txsMap for fixing the inconsistency between mem.txs and mem.txsMap Apr 14, 2022
@tnasu tnasu marked this pull request as ready for review April 14, 2022 13:48
@tnasu tnasu requested review from Kynea0b and torao as code owners April 14, 2022 13:48
@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Apr 15, 2022
Kynea0b
Kynea0b approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit 36dc585 into Finschia:main Apr 15, 2022
@tnasu tnasu deleted the main-fix-mempool branch April 28, 2022 08:02
@0Tech 0Tech mentioned this pull request Nov 1, 2023
Open
50 tasks
@0Tech 0Tech mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kynea0b Kynea0b Kynea0b approved these changes

@torao torao torao approved these changes

Assignees

@tnasu tnasu

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occur panic in resCbRecheck when sending about 400tx/s
3 participants
@tnasu @torao @Kynea0b