Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of function signChallenge() #485

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Optimization of function signChallenge() #485

merged 1 commit into from
Nov 9, 2022

Conversation

Mdaiki0730
Copy link
Member

Description

I think the function signChallenge() can be optimized to reduce the cyclomatic.

PR Checklist

@Mdaiki0730 Mdaiki0730 added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 8, 2022
@Mdaiki0730 Mdaiki0730 self-assigned this Nov 8, 2022
@Mdaiki0730 Mdaiki0730 merged commit 89101eb into Finschia:main Nov 9, 2022
@0Tech 0Tech mentioned this pull request Nov 1, 2023
Open
50 tasks
@Mdaiki0730 Mdaiki0730 mentioned this pull request Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@tnasu tnasu tnasu approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@Mdaiki0730 Mdaiki0730

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mdaiki0730 @torao @tnasu @Kynea0b