Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of the function ValidateBasic #504

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

Mdaiki0730
Copy link
Member

Description

The error message in the Line 459 of the function ValidateBasic() should be "wrong VotersHash".
I fixed it.

@Mdaiki0730 Mdaiki0730 added the D: invalid Decision: This doesn't seem right label Nov 22, 2022
@Mdaiki0730 Mdaiki0730 self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #504 (ebc3b99) into main (e6f57a1) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   65.39%   65.54%   +0.15%     
==========================================
  Files         278      278              
  Lines       37995    37972      -23     
==========================================
+ Hits        24846    24890      +44     
+ Misses      11328    11280      -48     
+ Partials     1821     1802      -19     
Impacted Files Coverage Δ
types/block.go 76.88% <100.00%> (+3.31%) ⬆️
blockchain/v0/reactor.go 66.10% <0.00%> (-3.39%) ⬇️
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
p2p/conn/connection.go 79.80% <0.00%> (-0.20%) ⬇️
p2p/switch.go 65.90% <0.00%> (ø)
crypto/vrf/vrf_libsodium.go
crypto/vrf/vrf_r2ishiguro.go 100.00% <0.00%> (ø)
consensus/state.go 73.38% <0.00%> (+0.11%) ⬆️
light/client.go 62.05% <0.00%> (+0.44%) ⬆️
p2p/pex/pex_reactor.go 80.28% <0.00%> (+0.61%) ⬆️
... and 7 more

@Mdaiki0730 Mdaiki0730 marked this pull request as ready for review November 22, 2022 07:07
@Mdaiki0730 Mdaiki0730 force-pushed the fix/validatebasic-typo branch from 8f0ab30 to a5a6250 Compare November 24, 2022 03:06
@Mdaiki0730 Mdaiki0730 force-pushed the fix/validatebasic-typo branch from a5a6250 to ebc3b99 Compare November 24, 2022 05:33
@torao torao added C: bug Classification: Something isn't working and removed D: invalid Decision: This doesn't seem right labels Nov 24, 2022
@Mdaiki0730 Mdaiki0730 merged commit 6c0f491 into Finschia:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants