Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reactor test failure #60

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix: reactor test failure #60

merged 1 commit into from
Apr 17, 2020

Conversation

egonspace
Copy link
Contributor

After #56, reactor_test often failed.
For example, TestReactorValidatorSetChanges test does not finish occasionally.

The reason is that when some peers receive proposal without starting the consensus, the thread was terminated by the nil pointer during the next processing.

func (cs *State) defaultSetProposal(proposal *types.Proposal) error {
...
	// Verify signature
	if !cs.Proposer.PubKey.VerifyBytes(...) { // nil pointer referencing
		...
	}
...

}

We should not use cs.Proposer in this function.

Closes: #XXX

Description


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@egonspace egonspace self-assigned this Apr 17, 2020
@egonspace egonspace added the C: bug Classification: Something isn't working label Apr 17, 2020
@egonspace egonspace mentioned this pull request Apr 17, 2020
5 tasks
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit ed623a2 into develop Apr 17, 2020
@egonspace egonspace deleted the fix/consensus_failure branch June 22, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants