Add a test for func nextRandom(rand *uint64) uint64
#605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nextRandom()` is a function defined locally. Add a test just in case. This guarantees the same output as general splitMix64().
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 66.21% 66.19% -0.03%
==========================================
Files 277 277
Lines 36969 36969
==========================================
- Hits 24478 24470 -8
- Misses 10725 10730 +5
- Partials 1766 1769 +3 |
Kynea0b
changed the title
func nextRandom(rand *uint64) uint64
ulbqb
added
the
C: enhancement
ulbqb
requested changes
May 15, 2023
ulbqb
requested changes
May 15, 2023
tnasu
approved these changes
May 15, 2023
ulbqb
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
func nextRandom(rand *uint64) uint64is a function defined locally. So, add a test just in case.This test guarantees the following for this local function:
The expected output is the same as that of general
splitMix64().