fix: remove unnecessary condition

[ulbqb]

Description

This PR removes unnecessary condition.

Issue

Regarding the connection side, the NewSignerListener supports the tcp and unix protocols.

ostracon/privval/utils.go

Lines 29 to 53 in 08c34d4

	func NewSignerListener(logger log.Logger, listenAddr string, remoteAddresses []string) (*SignerListenerEndpoint, error) {
	var listener net.Listener
	protocol, address := tmnet.ProtocolAndAddress(listenAddr)
	ln, err := net.Listen(protocol, address)
	if err != nil {
	return nil, err
	}
	switch protocol {
	case "unix":
	listener = NewUnixListener(ln)
	case "tcp":
	// TODO: persist this key so external signer can actually authenticate us
	listener = NewTCPListener(ln, ed25519.GenPrivKey())
	default:
	return nil, fmt.Errorf(
	"wrong listen address: expected either 'tcp' or 'unix' protocols, got %s",
	protocol,
	)
	}
	pve := NewSignerListenerEndpoint(logger.With("module", "privval"), listener, SignerListenerEndpointAllowAddress(protocol, remoteAddresses))
	return pve, nil
	}

Therefore, in the context of the if statement, there should not be any instances where the protocol field is empty, indicated by len(protocol) == 0.

ostracon/privval/signer_listener_endpoint.go

Lines 30 to 38 in 08c34d4

	func SignerListenerEndpointAllowAddress(protocol string, allowedAddresses []string) SignerListenerEndpointOption {
	return func(sl *SignerListenerEndpoint) {
	if protocol == "tcp" || len(protocol) == 0 {
	sl.connFilter = internal.NewIpFilter(allowedAddresses, sl.Logger)
	return
	}
	sl.connFilter = internal.NewNullObject()
	}
	}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.56%. Comparing base (2aa7d4c) to head (5144c7b).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   66.54%   66.56%   +0.02%     
==========================================
  Files         285      285              
  Lines       37919    37918       -1     
==========================================
+ Hits        25232    25239       +7     
+ Misses      10883    10880       -3     
+ Partials     1804     1799       -5     

Files	Coverage Δ
privval/signer_listener_endpoint.go	88.81% <100.00%> (+2.09%)	⬆️

... and 15 files with indirect coverage changes