Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change depending finschia-sdk to v0.48.0-rc2 and backport #81 #105

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Aug 25, 2023

Description

This PR includes cherry-pick #81 and v0.48.0-rc2 of the finschia-sdk has been adapted.
Along with that modification, the test has also been modified.

The message event has been moved to finschia-sdk.
Finschia/finschia-sdk@4c56c90

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 marked this pull request as ready for review August 25, 2023 10:22
@da1suk8 da1suk8 self-assigned this Aug 25, 2023
@da1suk8 da1suk8 requested a review from zemyblue August 25, 2023 10:23
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #105 (6c00a6e) into main (9dbd83e) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 6c00a6e differs from pull request most recent head e8c3f7b. Consider uploading reports for the commit e8c3f7b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   63.65%   63.40%   -0.26%     
==========================================
  Files          80       80              
  Lines       10001     9954      -47     
==========================================
- Hits         6366     6311      -55     
- Misses       3306     3313       +7     
- Partials      329      330       +1     
Files Changed Coverage Δ
x/wasm/keeper/msg_server.go 53.84% <ø> (-10.29%) ⬇️
x/wasmplus/keeper/msg_server.go 67.85% <ø> (-5.68%) ⬇️

... and 2 files with indirect coverage changes

zemyblue
zemyblue previously approved these changes Aug 25, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@da1suk8 da1suk8 changed the title build: change depending finschia-sdk to v0.48.0-rc2 build: change depending finschia-sdk to v0.48.0-rc2 and backport #81 Aug 25, 2023
Kynea0b
Kynea0b previously approved these changes Aug 25, 2023
@zemyblue zemyblue self-requested a review August 25, 2023 10:36
@da1suk8 da1suk8 dismissed stale reviews from Kynea0b and zemyblue via e8c3f7b August 25, 2023 10:36
@da1suk8 da1suk8 requested a review from Kynea0b August 25, 2023 10:37
@da1suk8 da1suk8 merged commit 053c7e4 into Finschia:main Aug 25, 2023
7 checks passed
@da1suk8 da1suk8 deleted the build/v0.48.0-rc2 branch August 25, 2023 10:58
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants