Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulid: update golang version to 1.20 #60

Merged
merged 4 commits into from
Jul 24, 2023
Merged

bulid: update golang version to 1.20 #60

merged 4 commits into from
Jul 24, 2023

Conversation

0Tech
Copy link

@0Tech 0Tech commented Jul 21, 2023

Description

closes: #59

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the ci label Jul 21, 2023
@0Tech 0Tech self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #60 (2dba15c) into main (0a1d457) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   60.89%   60.89%           
=======================================
  Files          80       80           
  Lines        9894     9894           
=======================================
  Hits         6025     6025           
  Misses       3553     3553           
  Partials      316      316           
Impacted Files Coverage Δ
x/wasm/types/errors.go 0.00% <ø> (ø)
x/wasm/types/test_fixtures.go 95.40% <100.00%> (ø)

@0Tech 0Tech marked this pull request as ready for review July 21, 2023 03:17
Copy link
Member

@da1suk8 da1suk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tell us why you used //nolint: to deal with lint errors. 851f16b

@0Tech
Copy link
Author

0Tech commented Jul 22, 2023

@0Tech 0Tech requested review from zemyblue and da1suk8 July 22, 2023 03:37
@0Tech 0Tech merged commit 164efa4 into Finschia:main Jul 24, 2023
@0Tech 0Tech deleted the golang branch July 24, 2023 02:01
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update golang version to 1.20
3 participants