Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor test cases for Params #69

Merged
merged 12 commits into from
Aug 18, 2023
Merged

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 14, 2023

Description

Params: TestQueryParams

Add a test case because we have not tested for Params.

// QueryParamsResponse is the response type for the Query/Params RPC method.
message QueryParamsResponse {
  // params defines the parameters of the module.
  Params params = 1 [ (gogoproto.nullable) = false ];
}

spec:
https://github.com/Finschia/wasmd/blob/main/proto/cosmwasm/wasm/v1/query.proto#L63

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b marked this pull request as ready for review August 14, 2023 05:40
@Kynea0b Kynea0b self-assigned this Aug 14, 2023
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description needs to be changed, because this pr just adds tests for other permissions.

x/wasm/keeper/querier_test.go Outdated Show resolved Hide resolved
@Kynea0b Kynea0b changed the title test: add test cases to Params refactor: add test cases to Params Aug 18, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@Kynea0b Kynea0b changed the title refactor: add test cases to Params refactor: refactor test cases to Params Aug 18, 2023
@Kynea0b Kynea0b changed the title refactor: refactor test cases to Params refactor: refactor test cases for Params Aug 18, 2023
@da1suk8 da1suk8 self-requested a review August 18, 2023 07:52
da1suk8
da1suk8 previously approved these changes Aug 18, 2023
@da1suk8 da1suk8 self-requested a review August 18, 2023 08:16
@Kynea0b Kynea0b merged commit f504ce8 into Finschia:main Aug 18, 2023
12 checks passed
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants