test: add pagination next key test in ContractHistory #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 170210 <j170210@icloud.com>
170210
changed the title
Signed-off-by: 170210 <j170210@icloud.com>
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
Kynea0b
reviewed
Aug 16, 2023
Signed-off-by: 170210 <j170210@icloud.com>
Kynea0b
previously approved these changes
Aug 16, 2023
da1suk8
previously approved these changes
Aug 16, 2023
|
In Description on this PR
-> "with pagination next key" is correct ? |
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
170210
force-pushed
the
fixup/contractHistory_nextKey
branch
from
39cf1b1 to
09a2da2
Compare
170210
force-pushed
the
fixup/contractHistory_nextKey
branch
2 times, most recently
from
154f090 to
2f9842b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 62.32% 62.29% -0.04%
==========================================
Files 80 80
Lines 9966 9966
==========================================
- Hits 6211 6208 -3
- Misses 3429 3431 +2
- Partials 326 327 +1 |
da1suk8
approved these changes
Aug 16, 2023
Kynea0b
approved these changes
Aug 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test case to ContractHistory function which calls "with pagination next key", since we have not tested when setting pagination next key.
How has this been tested?
Unit tests
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)