test: add a test case to verify ContractInfo gets correct IBCPortID #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
requested review from
da1suk8,
dudong2,
Kynea0b and
170210
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 62.89% 62.92% +0.03%
==========================================
Files 80 80
Lines 9965 9965
==========================================
+ Hits 6267 6270 +3
+ Misses 3373 3371 -2
+ Partials 325 324 -1 |
170210
approved these changes
Aug 23, 2023
dudong2
previously approved these changes
Aug 23, 2023
|
no need to add CHANGELOG? |
Kynea0b
approved these changes
Aug 23, 2023
needed, but there are many conflict PRs, so I am now waiting their merge |
loloicci
added a commit
that referenced
this pull request
Aug 23, 2023
…)" This reverts commit ec3dc9e.
loloicci
added a commit
that referenced
this pull request
Aug 23, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case to verify ContractInfo gets correct IBCPortID
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)