Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix automatic build shared library ci #127

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

170210
Copy link
Contributor

@170210 170210 commented Sep 12, 2023

Description

This pr is to fix a bug in deploy_to_git workflow.
Currently, Github secrets cannot be passed to the workflows triggered by forks. Therefore, in this PR, we have used push instead of pull_request.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 self-assigned this Sep 12, 2023
@170210 170210 added the bug Something isn't working label Sep 12, 2023
@170210 170210 merged commit f3de0bc into Finschia:main Sep 12, 2023
10 checks passed
@170210 170210 deleted the hotfix/auto_build branch September 12, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants