Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add static linking of wasmvm #46

Merged
merged 2 commits into from
Sep 30, 2021
Merged

feat: add static linking of wasmvm #46

merged 2 commits into from
Sep 30, 2021

Conversation

whylee259
Copy link
Contributor

Description

This PR adds an option to link wasmvm statically on the consumer side.
(By adding build tag static)

  • add an option to link statically
  • add shared and static libs to api/.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@whylee259 whylee259 self-assigned this Sep 28, 2021
brew0722
brew0722 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than, LGTM

Makefile
@@ -58,26 +58,28 @@ test-safety:
# Creates a release build in a containerized build environment of the static library for Alpine Linux (.a)
release-build-alpine:
rm -rf target/release
# build the muslc *.a file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpine uses muslc as it is, so how about leave this comment? 'build the muslc'
I think it seems easy to understand why Alpine has a separate build logic just by looking at the makefile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the comments as your opinion.

@brew0722
Copy link
Contributor

I found some related issue about why created shared. CosmWasm/wasmvm#45
I think maybe we need to check license also.

@brew0722 brew0722 self-requested a review September 29, 2021 01:47
brew0722
brew0722 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whylee259's reviewed the license and check that there are no issues. LGTM

shiki-tak
shiki-tak approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whylee259 whylee259 merged commit 3015fc4 into Finschia:main Sep 30, 2021
@tnasu tnasu mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@brew0722 brew0722 brew0722 approved these changes

@loloicci loloicci Awaiting requested review from loloicci

Assignees

@whylee259 whylee259

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whylee259 @brew0722 @shiki-tak