Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PocoNavigator.Value is too expensive #482

Closed
ewoutkramer opened this issue Nov 21, 2017 · 2 comments · Fixed by #1882
Closed

PocoNavigator.Value is too expensive #482

ewoutkramer opened this issue Nov 21, 2017 · 2 comments · Fixed by #1882
Assignees

Comments

@ewoutkramer
Copy link
Member

The Value property of IElementNavigator is accessed pretty frequently by all the supporting infrastructure (Validator, FhirPath evaluator, serializer) and therefore needs to be fast. The current implementation will frequently call out to methods that parse and serialize raw values - which takes too much time.

I propose we cache this property in the PocoNavigator.

@ewoutkramer
Copy link
Member Author

Discovered by @marcovisserFurore

@ewoutkramer
Copy link
Member Author

Note, the PocoNavigator is now an empty shell, just calling ITypedElement.Value, which is generally implemented by TypedElement.Value (which still has the same problem) or PocoElementNode.Value (which just does some casting). So, now, we should look at TypedElement.Value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants