Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToTypedElementOnSourceNode: caching children and value #1882

Merged
merged 8 commits into from
Oct 12, 2021
Merged

ToTypedElementOnSourceNode: caching children and value #1882

merged 8 commits into from
Oct 12, 2021

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented Sep 23, 2021 •
edited
Loading

Description

The Value property of TypedElementOnSourceNode is an expensive property and is called frequently. So caching will increase performance. This has only effect when the Value is accessed repeatedly.
Value is now lazy initialized.

Related issues

Resolves #482

Related Pull Request

See also PR FirelyTeam/firely-net-common#157

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

ewoutkramer
ewoutkramer reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@ewoutkramer ewoutkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the /results directory? I did not do it for the serializer/deserializer, but maybe it's nice as a reference (though useless across different machines....)

@marcovisserFurore marcovisserFurore marked this pull request as ready for review October 5, 2021 15:53
@marcovisserFurore
Copy link
Member Author

Should we include the /results directory? I did not do it for the serializer/deserializer, but maybe it's nice as a reference (though useless across different machines....)

This is not relevant anymore

@marcovisserFurore marcovisserFurore merged commit d676578 into develop-stu3 Oct 12, 2021
@marcovisserFurore marcovisserFurore deleted the feature/482-CachingTypedElementValue branch October 12, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoutkramer ewoutkramer ewoutkramer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PocoNavigator.Value is too expensive
2 participants
@marcovisserFurore @ewoutkramer