Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1442: Added Quantity arithmetic #2595

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented Sep 19, 2023

Description

Added the Quantity arithmetic operations, like Add, Substract, Multiply and Divide. These operations can now also be used in FhirPath.

I changed the signature of the not implemented static operators of Quantity. Technically is that a breaking change, but here we can get away with it or not?

Related issues

Resolves #1442.

Testing

  • Hl7.Fhir.ElementModel.Tests.QuantityTests.ArithmeticOperationsTests
  • HL7.FhirPath.Tests.OperationsTests.AssertTestcases

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@ewoutkramer
Copy link
Member

ewoutkramer commented Sep 21, 2023

I changed the signature of the not implemented static operators of Quantity. Technically is that a breaking change, but here we can get away with it or not?

Technically, yes, but we would only bother people who had used the addition operators to cause a NotImplementedException. The bool return type also was clearly a copy/paste error!

I think we can safely make this change.

@ewoutkramer ewoutkramer merged commit e661642 into develop Sep 21, 2023
15 checks passed
@ewoutkramer ewoutkramer deleted the feature/1442-quantity-arithmetic branch September 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FhirPath] Add support for Quantity arithmetic
2 participants