-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create duplicate invariant key validator #184
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
abdd1cf
Create duplicate invariant key validator
mmsmits e986cc2
Merge branch 'develop' into feature/143-validate-constraint-uniqueness
ewoutkramer cc5a7a8
Merge branch 'develop' into feature/143-validate-constraint-uniqueness
mmsmits 5d540a9
minor improvements
mmsmits be4d146
Merge branch 'develop' into feature/143-validate-constraint-uniqueness
ewoutkramer 2fcaa74
fixing review comments
mmsmits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,10 +20,8 @@ public class StructureDefinitionValidator : IValidatable | |
/// <inheritdoc/> | ||
public ResultReport Validate(ITypedElement input, ValidationContext vc, ValidationState state) | ||
{ | ||
var evidence = new List<ResultReport>(); | ||
|
||
//this can be expanded with other validate functionality | ||
evidence.AddRange(validateInvariantUniqueness(input, state)); | ||
var evidence = validateInvariantUniqueness(input, state).ToList(); | ||
|
||
return ResultReport.FromEvidence(evidence); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to create a list:
If there are multiple steps in the future, you can just do
|
||
} | ||
|
@@ -46,7 +44,7 @@ private static IEnumerable<ResultReport> validateInvariantUniqueness(ITypedEleme | |
return snapshotEvidence.Concat(diffEvidence).Select(i => i.AsResult(input, state)); | ||
} | ||
|
||
private static IEnumerable<IssueAssertion> validateInvariantUniqueness(IEnumerable<ITypedElement> elements) | ||
private static List<IssueAssertion> validateInvariantUniqueness(IEnumerable<ITypedElement> elements) | ||
{ | ||
//Selects the combination of key and elementDefintion path for the duplicate keys where the paths are not also the same. | ||
|
||
|
@@ -62,7 +60,7 @@ private static IEnumerable<IssueAssertion> validateInvariantUniqueness(IEnumerab | |
.Distinct())) //Distinct to remove paths that are encountered multiple times per invariant | ||
.Where(kv => kv.Paths.Count() > 1); //Remove entries that only have a single path. These are not incorrect. | ||
|
||
return PathsPerDuplicateInvariantKey.Select(c => new IssueAssertion(Issue.PROFILE_ELEMENTDEF_INCORRECT, $"Duplicate key '{c.Key}' in paths: {string.Join(", ", c.Paths)}")); | ||
return PathsPerDuplicateInvariantKey.Select(c => new IssueAssertion(Issue.PROFILE_ELEMENTDEF_INCORRECT, $"Duplicate key '{c.Key}' in paths: {string.Join(", ", c.Paths)}")).ToList(); | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your new function already returns a list now, so, this should not be necessary anymore!